Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

feat: Unmarshal Nonce type #1862

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat: Unmarshal Nonce type #1862

merged 1 commit into from
Aug 30, 2023

Conversation

leovct
Copy link
Member

@leovct leovct commented Aug 30, 2023

Description

When trying to unmarshal types.Block, there is an issue with types.Nonce. The type is missing its custom UnmarshalText method.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Here's an example of a CI job deserialising a block: https://github.com/leovct/edge-grpc-mock-server/actions/runs/6025058222/job/16345020813#step:6:38

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@leovct
Copy link
Member Author

leovct commented Aug 30, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 30, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcastellm vcastellm merged commit bbfbad0 into 0xPolygon:feat/zero Aug 30, 2023
2 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@leovct leovct deleted the feat/zero-leo branch August 31, 2023 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants