[Feature] Double-signing slashing

Makefile

@@ -73,7 +73,7 @@ test-e2e: check-go
 .PHONY: test-e2e-polybft
 test-e2e-polybft: check-go
 	go build -o artifacts/polygon-edge .
-	env EDGE_BINARY=${PWD}/artifacts/polygon-edge E2E_TESTS=true E2E_LOGS=true \
+	env EDGE_BINARY=${PWD}/artifacts/polygon-edge E2E_TESTS=true E2E_LOGS=true BYZANTINE_BINARY=${PWD}/e2e-polybft/e2e/polygon-edge-byzantine \
 	go test -v -timeout=1h30m ./e2e-polybft/e2e/...
 
 .PHONY: test-property-polybft

chain/params.go

@@ -92,6 +92,7 @@ const (
 	TxHashWithType      = "txHashWithType"
 	LondonFix           = "londonfix"
 	Governance          = "governance"
+	DoubleSignSlashing  = "doubleSignSlashing"
 )
 
 // Forks is map which contains all forks and their starting blocks from genesis
@@ -129,6 +130,7 @@ func (f *Forks) At(block uint64) ForksInTime {
 		TxHashWithType:      f.IsActive(TxHashWithType, block),
 		LondonFix:           f.IsActive(LondonFix, block),
 		Governance:          f.IsActive(Governance, block),
+		DoubleSignSlashing:  f.IsActive(DoubleSignSlashing, block),
 	}
 }
 
@@ -159,7 +161,8 @@ type ForksInTime struct {
 	QuorumCalcAlignment,
 	TxHashWithType,
 	LondonFix,
-	Governance bool
+	Governance,
+	DoubleSignSlashing bool
 }
 
 // AllForksEnabled should contain all supported forks by current edge version
@@ -177,4 +180,5 @@ var AllForksEnabled = &Forks{
 	TxHashWithType:      NewFork(0),
 	LondonFix:           NewFork(0),
 	Governance:          NewFork(0),
+	DoubleSignSlashing:  NewFork(0),
 }

command/genesis/params.go

@@ -16,7 +16,7 @@ import (
 	"github.com/0xPolygon/polygon-edge/consensus/ibft"
 	"github.com/0xPolygon/polygon-edge/consensus/ibft/fork"
 	"github.com/0xPolygon/polygon-edge/consensus/ibft/signer"
-	"github.com/0xPolygon/polygon-edge/consensus/polybft"
+	"github.com/0xPolygon/polygon-edge/consensus/polybft/common"
 	"github.com/0xPolygon/polygon-edge/contracts/staking"
 	stakingHelper "github.com/0xPolygon/polygon-edge/helper/staking"
 	"github.com/0xPolygon/polygon-edge/server"
@@ -133,7 +133,7 @@ type genesisParams struct {
 	accessListsOwner                 string
 
 	nativeTokenConfigRaw string
-	nativeTokenConfig    *polybft.TokenConfig
+	nativeTokenConfig    *common.TokenConfig
 
 	premineInfos []*premineInfo
 
@@ -576,7 +576,7 @@ func (p *genesisParams) isBurnContractEnabled() bool {
 // extractNativeTokenMetadata parses provided native token metadata (such as name, symbol and decimals count)
 func (p *genesisParams) extractNativeTokenMetadata() error {
 	if p.nativeTokenConfigRaw == "" {
-		p.nativeTokenConfig = &polybft.TokenConfig{
+		p.nativeTokenConfig = &common.TokenConfig{
 			Name:       defaultNativeTokenName,
 			Symbol:     defaultNativeTokenSymbol,
 			Decimals:   defaultNativeTokenDecimals,
@@ -627,7 +627,7 @@ func (p *genesisParams) extractNativeTokenMetadata() error {
 		owner = types.StringToAddress(strings.TrimSpace(params[4]))
 	}
 
-	p.nativeTokenConfig = &polybft.TokenConfig{
+	p.nativeTokenConfig = &common.TokenConfig{
 		Name:       name,
 		Symbol:     symbol,
 		Decimals:   uint8(decimals),

command/genesis/params_test.go

@@ -8,7 +8,7 @@ import (
 	"github.com/umbracle/ethgo"
 
 	"github.com/0xPolygon/polygon-edge/command"
-	"github.com/0xPolygon/polygon-edge/consensus/polybft"
+	"github.com/0xPolygon/polygon-edge/consensus/polybft/common"
 	"github.com/0xPolygon/polygon-edge/types"
 )
 
@@ -18,13 +18,13 @@ func Test_extractNativeTokenMetadata(t *testing.T) {
 	cases := []struct {
 		name        string
 		rawConfig   string
-		expectedCfg *polybft.TokenConfig
+		expectedCfg *common.TokenConfig
 		expectErr   bool
 	}{
 		{
 			name:      "default token config",
 			rawConfig: "",
-			expectedCfg: &polybft.TokenConfig{
+			expectedCfg: &common.TokenConfig{
 				Name:       defaultNativeTokenName,
 				Symbol:     defaultNativeTokenSymbol,
 				Decimals:   defaultNativeTokenDecimals,
@@ -66,7 +66,7 @@ func Test_extractNativeTokenMetadata(t *testing.T) {
 		{
 			name:      "non-mintable valid config",
 			rawConfig: "MyToken:MTK:9:false",
-			expectedCfg: &polybft.TokenConfig{
+			expectedCfg: &common.TokenConfig{
 				Name:       "MyToken",
 				Symbol:     "MTK",
 				Decimals:   9,
@@ -78,7 +78,7 @@ func Test_extractNativeTokenMetadata(t *testing.T) {
 		{
 			name:      "non-mintable token config, owner provided but ignored",
 			rawConfig: "MyToken:MTK:9:false:0x123456789",
-			expectedCfg: &polybft.TokenConfig{
+			expectedCfg: &common.TokenConfig{
 				Name:       "MyToken",
 				Symbol:     "MTK",
 				Decimals:   9,
@@ -90,7 +90,7 @@ func Test_extractNativeTokenMetadata(t *testing.T) {
 		{
 			name:      "mintable token valid config",
 			rawConfig: "MyMintToken:MMTK:9:true:0x123456789",
-			expectedCfg: &polybft.TokenConfig{
+			expectedCfg: &common.TokenConfig{
 				Name:       "MyMintToken",
 				Symbol:     "MMTK",
 				Decimals:   9,

command/genesis/polybft_params.go

@@ -15,6 +15,7 @@ import (
 	"github.com/0xPolygon/polygon-edge/command"
 	"github.com/0xPolygon/polygon-edge/command/helper"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft"
+	polyCommon "github.com/0xPolygon/polygon-edge/consensus/polybft/common"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft/contractsapi"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft/contractsapi/artifact"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft/validator"
@@ -175,7 +176,7 @@ func (p *genesisParams) generatePolyBftChainConfig(o command.OutputFormatter) er
 		proposalQuorum = proposalQuorumMax
 	}
 
-	polyBftConfig := &polybft.PolyBFTConfig{
+	polyBftConfig := &polyCommon.PolyBFTConfig{
 		InitialValidatorSet: initialValidators,
 		BlockTime:           common.Duration{Duration: p.blockTime},
 		EpochSize:           p.epochSize,
@@ -189,13 +190,13 @@ func (p *genesisParams) generatePolyBftChainConfig(o command.OutputFormatter) er
 		MaxValidatorSetSize:  p.maxNumValidators,
 		CheckpointInterval:   p.checkpointInterval,
 		WithdrawalWaitPeriod: p.withdrawalWaitPeriod,
-		RewardConfig: &polybft.RewardsConfig{
+		RewardConfig: &polyCommon.RewardsConfig{
 			TokenAddress:  rewardTokenAddr,
 			WalletAddress: walletPremineInfo.address,
 			WalletAmount:  walletPremineInfo.amount,
 		},
 		BlockTimeDrift: p.blockTimeDrift,
-		GovernanceConfig: &polybft.GovernanceConfig{
+		GovernanceConfig: &polyCommon.GovernanceConfig{
 			VotingDelay:              voteDelay,
 			VotingPeriod:             votingPeriod,
 			ProposalThreshold:        proposalThreshold,
@@ -369,7 +370,7 @@ func (p *genesisParams) generatePolyBftChainConfig(o command.OutputFormatter) er
 
 func (p *genesisParams) deployContracts(
 	rewardTokenByteCode []byte,
-	polybftConfig *polybft.PolyBFTConfig,
+	polybftConfig *polyCommon.PolyBFTConfig,
 	chainConfig *chain.Chain,
 	burnContractAddr types.Address) (map[types.Address]*chain.GenesisAccount, error) {
 	type contractInfo struct {

command/genesis/utils.go

@@ -14,6 +14,7 @@ import (
 	"github.com/0xPolygon/polygon-edge/command"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft/bitmap"
+	polyCommon "github.com/0xPolygon/polygon-edge/consensus/polybft/common"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft/validator"
 	"github.com/0xPolygon/polygon-edge/consensus/polybft/wallet"
 	"github.com/0xPolygon/polygon-edge/helper/common"
@@ -124,7 +125,7 @@ func parseTrackerStartBlocks(trackerStartBlocksRaw []string) (map[types.Address]
 }
 
 // parseBurnContractInfo parses provided burn contract information and returns burn contract block and address
-func parseBurnContractInfo(burnContractInfoRaw string) (*polybft.BurnContractInfo, error) {
+func parseBurnContractInfo(burnContractInfoRaw string) (*polyCommon.BurnContractInfo, error) {
 	// <block>:<address>[:<burn destination address>]
 	burnContractParts := strings.Split(burnContractInfoRaw, ":")
 	if len(burnContractParts) < 2 || len(burnContractParts) > 3 {
@@ -144,7 +145,7 @@ func parseBurnContractInfo(burnContractInfoRaw string) (*polybft.BurnContractInf
 	}
 
 	if len(burnContractParts) == 2 {
-		return &polybft.BurnContractInfo{
+		return &polyCommon.BurnContractInfo{
 			BlockNumber:        blockNum,
 			Address:            types.StringToAddress(contractAddress),
 			DestinationAddress: types.ZeroAddress,
@@ -156,7 +157,7 @@ func parseBurnContractInfo(burnContractInfoRaw string) (*polybft.BurnContractInf
 		return nil, fmt.Errorf("failed to parse burn destination address %s: %w", destinationAddress, err)
 	}
 
-	return &polybft.BurnContractInfo{
+	return &polyCommon.BurnContractInfo{
 		BlockNumber:        blockNum,
 		Address:            types.StringToAddress(contractAddress),
 		DestinationAddress: types.StringToAddress(destinationAddress),