Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor fixes #90

Merged
merged 2 commits into from
Apr 26, 2024
Merged

chore: minor fixes #90

merged 2 commits into from
Apr 26, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Apr 26, 2024

Description

References (if applicable)

@leovct leovct mentioned this pull request Apr 26, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jhkimqd jhkimqd self-requested a review April 26, 2024 08:08
@leovct leovct enabled auto-merge (squash) April 26, 2024 08:09
jhkimqd
jhkimqd approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@jhkimqd jhkimqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leovct leovct merged commit 8676821 into main Apr 26, 2024
7 checks passed
@leovct leovct deleted the chore/minor-fixes branch April 26, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhkimqd jhkimqd jhkimqd approved these changes

@praetoriansentry praetoriansentry Awaiting requested review from praetoriansentry praetoriansentry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @jhkimqd