test: add attaching a third PP network into the CI #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ji Hwan <[email protected]>
Signed-off-by: Ji Hwan <[email protected]>
Signed-off-by: Ji Hwan <[email protected]>
Signed-off-by: Ji Hwan <[email protected]>
leovct
approved these changes
Nov 25, 2024
| "cdk_node_image": "ghcr.io/0xpolygon/cdk:0.4.0-beta10", # https://github.com/0xpolygon/cdk/pkgs/container/cdk | ||
| "cdk_validium_node_image": "0xpolygon/cdk-validium-node:0.7.0-cdk", # https://hub.docker.com/r/0xpolygon/cdk-validium-node/tags | ||
| "zkevm_bridge_proxy_image": "haproxy:3.0-bookworm", # https://hub.docker.com/_/haproxy/tags | ||
| "zkevm_bridge_service_image": "hermeznetwork/zkevm-bridge-service:v0.6.0-RC1", # https://hub.docker.com/r/hermeznetwork/zkevm-bridge-service/tags | ||
| "zkevm_bridge_ui_image": "leovct/zkevm-bridge-ui:multi-network", # https://hub.docker.com/r/leovct/zkevm-bridge-ui/tags | ||
| "zkevm_contracts_image": "leovct/zkevm-contracts:v8.0.0-rc.4-fork.12", # https://hub.docker.com/repository/docker/leovct/zkevm-contracts/tags | ||
| "zkevm_contracts_image": "nulyjkdhthz/zkevm-contracts:v9.0.0-rc.3-pp-fork.12", # https://hub.docker.com/repository/docker/leovct/zkevm-contracts/tags |
There was a problem hiding this comment.
I guess we could use leovct/zkevm-contracts:v9.0.0-rc.3-pp-fork.12 but not 100% sure if it works as expected. cc @praetoriansentry
|
This would ideally integrate SP1 prover keys with Github secrets. I think we can follow up after we get a test key for CI purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds another step to attach a third PP network in addition to the existing steps, and does a minimal check by sending a simple transfer in that network. The test CI seems to be passing.
This is however dependent on using the PP CDK Erigon and Contract images, so it may be better to hold until the latest images are applied on the
mainbranch first: