Reporting offchain data gap detection #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begmaroman
commented
Jul 4, 2024
| ALTER TABLE data_node.offchain_data DROP COLUMN IF EXISTS batch_num; | ||
|
|
||
| -- +migrate Up | ||
| ALTER TABLE data_node.offchain_data | ||
| ADD COLUMN IF NOT EXISTS batch_num BIGINT NOT NULL DEFAULT 0; | ||
|
|
||
| -- Ensure batch_num is indexed for optimal performance |
There was a problem hiding this comment.
Decided to modify an existing migration since it was added in the previous PR and was not deployed anywhere yet. It should be ok in this particular case.
# Conflicts: # services/status/status_test.go # synchronizer/batches.go
vcastellm
reviewed
Jul 16, 2024
vcastellm
approved these changes
Jul 16, 2024
|
goran-ethernal
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.