Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): solve issue with foundry remappings #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0xGabi
Copy link

@0xGabi 0xGabi commented Feb 19, 2023

Hi, thank you for working on this. Super helpful when dealing with proxies and foundry!

Would like to propose this small update because since I upgrade to the latest nightly version of forge I started having this issue: foundry-rs/foundry#3440.

@0xPhaze
Copy link
Owner

0xPhaze commented Feb 20, 2023

Hi Gabi, thanks for your interest and for reporting this.
I can't reproduce the issue myself. Everything seems to be working as expected on the latest foundry version. Or perhaps I don't fully understand the issue.

Did you look into the discussion at

Do you have auto_detect_remappings = true in your foundry.toml?
Can you maybe share a repository where this is an issue?

@0xGabi
Copy link
Author

0xGabi commented Feb 20, 2023

Oh I didn't know about that config for foundry.toml. I just give it a try and it is still an issue for me 🤔

Here is the project were we are working with upgrade-scripts:

Note that I update the submodule to point to our forked version: https://github.com/BlossomLabs/OsmoticFund/blob/controller-tests/.gitmodules#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants