Kyber getRates code is unclear.md

105 - Kyber getRates code is unclear

Function names don't reflect their true functionalities, and the code uses some undocumented assumptions.

Recommendation:

Refactor the code to separate getting rate functionality with getSellRate and getBuyRate. Explicitly document any assumptions in the code (slippage, etc).

Slide Screenshot

---

Slide Text

• ConsenSys Audit DeFi Saver Finding 5.6
• Naming/Documentation/Refactoring
• Misleading Function Names & Assumptions
• Refactor Code Document Assumptions

---

References

• Youtube Reference
• ConsenSys's Audit of DeFi Saver

---

Tags