Skip to content

Latest commit

 

History

History
26 lines (22 loc) · 981 Bytes

Unchecked return value for `IWETH.transfer` call.md

File metadata and controls

26 lines (22 loc) · 981 Bytes

In EthUniswapPCVController, there is a call to IWETH.transfer that does not check the return value.

It is usually good to add a require-statement that checks the return value or to use something like safeTransfer; unless one is sure the given token reverts in case of a failure.

Recommendation:

Consider adding a require-statement or using `safeTransfer_


Slide Screenshot

015.jpg


Slide Text

  • ConsenSys Audit Fei Finding 3.7
  • Error Handling
  • Medium Severity
  • Unchecked Return Values
  • ERC20 Transfer
  • Add require or Use SafeERC20 Wrapper

References


Tags