The function notifyRewardAmount()
will revert if block.timestamp >= periodFinish
.
However this function is called indirectly via the Synthetix.mint()
function.
A revert here would cause the external call to fail and thereby halt the mint process.
Synthetix.mint()
cannot be successfully called until enough time has elapsed for the period to finish.
Consider handling the case where the reward period has not elapsed without reverting the call.
- Sigma Prime Unipool Finding 3
- Error Handling
- High Severity
- External Call Reverts -> Mint Blocked
- Handle Condition Without Reverting
- Youtube Reference
- High Risk severity finding from Sigma Prime's Audit of Synthetix Unipool