-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file data resolvers #120
Open
AnotherRegularDude
wants to merge
10
commits into
0exp:master
Choose a base branch
from
umbrellio:feature/add-file-loading-by-scheme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add file data resolvers #120
AnotherRegularDude
wants to merge
10
commits into
0exp:master
from
umbrellio:feature/add-file-loading-by-scheme
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basherru
reviewed
Oct 20, 2020
basherru
reviewed
Oct 20, 2020
basherru
reviewed
Oct 20, 2020
AnotherRegularDude
force-pushed
the
feature/add-file-loading-by-scheme
branch
from
October 23, 2020 14:38
4325da1
to
f6f453c
Compare
AnotherRegularDude
force-pushed
the
feature/add-file-loading-by-scheme
branch
from
December 21, 2020 23:29
6e40a16
to
a8b695a
Compare
Вот бы вмержировать ето :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use scheme in file_path to specify how we should load file content. So, I implement file content resolving logic:
DSL
methods, which helps define custom resolversfile
resolvervault
resolver inVault
gem