Update Github actions and pre-commit hooks

.github/workflows/pre-commit.yml

@@ -8,5 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-python@v4
-      - uses: pre-commit/[email protected]
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - uses: pre-commit/[email protected]

.github/workflows/unittests.yml

@@ -14,7 +14,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python }}
       - name: Install tox

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 ---
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v5.0.0
     hooks:
       - id: check-added-large-files
       - id: check-case-conflict
@@ -23,7 +23,7 @@ repos:
       - id: forbid-tabs
 
   - repo: https://github.com/igorshubovych/markdownlint-cli
-    rev: v0.39.0
+    rev: v0.43.0
     hooks:
       - id: markdownlint
 
@@ -42,7 +42,7 @@ repos:
         exclude: ^ejabberd_example.yml$
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.4.5
+    rev: v0.8.0
     hooks:
       - id: ruff
         args:

xpartamupp/echelon.py

@@ -288,9 +288,7 @@ def _verify_game(game_report):
             jid for jid, state in game_report["playerStates"].items() if state == "won"
         ]
         # We only support 1v1s right now.
-        if len(winning_jids) > 1 or len(dict.keys(game_report["playerStates"])) != 2:
-            return False
-        return True
+        return len(winning_jids) == 1 and len(dict.keys(game_report["playerStates"])) == 2
 
     def _rate_game(self, game):
         """Update player ratings based on game outcome.

xpartamupp/elo.py

@@ -64,7 +64,7 @@ def get_rating_adjustment(rating, opponent_rating, games_played, _opponent_games
     """
     if rating < -2199 or opponent_rating < -2199:
         raise ValueError(
-            "Too small rating given: rating: %i, opponent rating: %i" % (rating, opponent_rating)
+            f"Too small rating given: rating: {rating}, opponent rating: {opponent_rating}"
         )
 
     rating_k_factor = (

xpartamupp/stanzas.py

@@ -83,8 +83,7 @@ def get_game(self):
         data = {}
 
         if game is not None:
-            for key, item in game.items():
-                data[key] = item
+            data = dict(game.items())
         return data
 
 
@@ -119,8 +118,7 @@ def get_game(self):
         data = {}
 
         if game is not None:
-            for key, item in game.items():
-                data[key] = item
+            data = dict(game.items())
         return data