Refactor logging for more granularity #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the use of the logger used for logging by the bots from the root logger to a module specific logger, which provides more flexibility in terms of configuration. It also changes the command line options of the bots to configure the verbosity of logging. This allows introducing an additional verbosity level which uses debug logging for the bots themselves, but doesn't do the same for third-party libraries used by them. This helps reducing often undesired high-volume debug logs by libraries like Slixmpp, while still generating debug logs for our custom code.
Dunedan
force-pushed
the
refactor-logging
branch
from
1eb48c5 to
f4035ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the use of the logger used for logging by the bots from the root logger to a module specific logger, which provides more flexibility in terms of configuration.
It also changes the command line options of the bots to configure the verbosity of logging. This allows introducing an additional verbosity level which uses debug logging for the bots themselves, but doesn't do the same for third-party libraries used by them. This helps reducing often undesired high-volume debug logs by libraries like Slixmpp, while still generating debug logs for our custom code.