Add dummy implementations to satisfy new IOBluetoothDeviceInquiryDelegate protocol in 10.8 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszkopinski
pushed a commit
to bartoszkopinski/lightblue-0.4
that referenced
this pull request
Jan 13, 2014
Fixes selectdevice() GUI dialog
bartoszkopinski
pushed a commit
to bartoszkopinski/lightblue-0.4
that referenced
this pull request
Jan 13, 2014
…lementations. This patch is from: <pipt@601beb5> I tested that it works with 10.8.2 and our current libpebble readme already states use with 10.8.3+ is required. Without this patch 10.8.2 does not work either. This suggests that all versions of 10.8 might require the patch and given we only explicitly support 10.8 then I think we should just pull the patch into our master. (This would also mean we don't need to redirect people to <https://github.com/pipt/lightblue-0.4/>.) Related issues/patches: * <0-1-0#2> * <0-1-0#3> * <0-1-0#4>
|
Please merge this. |
0-1-0
added a commit
that referenced
this pull request
Oct 23, 2014
Add dummy implementations to satisfy new IOBluetoothDeviceInquiryDelegate protocol in 10.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author of #2 and I have both found that the latest versions of Mac OS X (10.8.2 here, and 10.8.3 for him) have new required methods in the IOBluetoothDeviceInquiryDelegate protocol. I've added some no-op methods in order to satisfy the protocol and to allow LightBlue to continue.
Thanks for posting this updated version! It's been a big help.