Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Hide/Show button props #29

Open
felipesilvati opened this issue Feb 2, 2018 · 3 comments
Open

Initial Hide/Show button props #29

felipesilvati opened this issue Feb 2, 2018 · 3 comments

Comments

@felipesilvati
Copy link

It would be very helpful if I could define through a boolean props the initial state of the show/hide button. (hidden by default)

Thanks!

@felipesilvati
Copy link
Author

It's only a matter of setting the "passwordShown" initial state from a prop instead of hardcoding to false:

https://github.com/zakangelle/react-password-mask/blob/8b338ac5aecdb457993cd0c1f842195fd0185e00/src/index.js#L49-L52

@felipesilvati
Copy link
Author

I'd be willing to work on that if you think it's a good idea. Cheers!

@channox32
Copy link

Maybe you can fork this repo and try to add those feature you have in mind, and create a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants