Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bloating previous author's contribution stats #107

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Avoid bloating previous author's contribution stats #107

merged 2 commits into from
Nov 10, 2023

Conversation

i-ky
Copy link
Contributor

@i-ky i-ky commented Aug 1, 2023

Otherwise GitHub counts each force-push of an amended commit as a contribution by the original author, which may lead to hundreds and thousands of "fake" contributions provided that action typically runs multiple times a day.

This is a #101 fixup (see #101 (comment)) and an alternative to #105.

I use my fork/branch for OSMLatvija/zulip-archive and it seems to work just fine.

i-ky added 2 commits August 1, 2023 16:00
Otherwise GitHub counts each force-push of an amended commit
as a contribution by the original author, which may lead
to hundreds and thousands of "fake" contributions provided
that action typically runs multiple times a day.
@i-ky
Copy link
Contributor Author

i-ky commented Nov 10, 2023

@rht, @timabbott, could you please give me some feedback?

@rht
Copy link
Contributor

rht commented Nov 10, 2023

LGTM.

On another note, I have one case: I have sometimes added extra commits to my archive repo for maintenance purpose (e.g. updating the GA workflow yml, readme, etc). This results in more than 1 commits to the repo, and the GA amends the last commit regardless of whether it is maintenance commit, or the commit that adds the archive HTML files. And thus results in several versions of the archive files. But this problem can be avoided by always amending the only commit in the repo anyway, even if it is for maintenance.

@i-ky
Copy link
Contributor Author

i-ky commented Nov 10, 2023

But this problem can be avoided by always amending the only commit in the repo anyway, even if it is for maintenance.

Or one can use git rebase --interactive to reorder commits in such a way, that the commit that adds the archive HTML files remains the last one.

@timabbott timabbott merged commit 5ff6072 into zulip:master Nov 10, 2023
2 checks passed
@timabbott
Copy link
Member

Merged, thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants