-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type to session nodes #3309
Add type to session nodes #3309
Conversation
Signed-off-by: Peter Moogk <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 116 116
Lines 12046 12047 +1
Branches 2651 2655 +4
=======================================
+ Hits 11206 11207 +1
Misses 839 839
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Peter Moogk <[email protected]>
…-explorer-vscode into Add_type_info_to_session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @petermoogk,
Curious if we can add (or update) some unit tests that will capture this addition to the context values 🙏
Co-authored-by: Fernando Rijo Cedeno <[email protected]> Signed-off-by: Peter Moogk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @petermoogk,
Would you mind adding (or updating) a small test which verifies that the profile type is added to the context value for each tree?
I'm thinking either a new (or updated) test in each of these files:
- packages/zowe-explorer/tests/unit/trees/uss/USSTree.unit.test.ts
- packages/zowe-explorer/tests/unit/trees/dataset/DatasetTree.unit.test.ts
- packages/zowe-explorer/tests/unit/trees/job/JobTree.unit.test.ts
Signed-off-by: Peter Moogk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks @petermoogk for the enhancement!
I noticed there are conflicts, I can re-approve once they are resolved.
Signed-off-by: Peter Moogk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
packages/zowe-explorer/__tests__/__unit__/trees/job/JobTree.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Peter Moogk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @petermoogk
Proposed changes
Currently, the contextValue for a Zowe tree node does not encode the profile type. This makes it difficult for an extender to add a context menu action that should be visible for a specific profile type. This PR includes code that updates the context value for each of the three zowe views(ie data set, uss, and jobs). Each contextValue has "_type=<profile_type>" appended to the end.
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments