Add ability to search Data Sets and PDS contents

[awharn]

Proposed changes

Added the ability to search data sets from a session node with a filter applied, or a PDS node. Also applies to favorited searches and PDS nodes.

Release Notes

Milestone: 3.1.0

Changelog: See changelog files

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

Attention: Patch coverage is 97.93814% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (d68621f) to head (0ee66b0).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../zowe-explorer/src/trees/dataset/DatasetActions.ts	97.70%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
+ Coverage   93.10%   93.13%   +0.03%     
==========================================
  Files         117      117              
  Lines       12149    12244      +95     
  Branches     2790     2810      +20     
==========================================
+ Hits        11311    11404      +93     
- Misses        837      839       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

This looks awesome so far, thanks Andrew for working on this! I appreciate the attention to detail for these tests 😋

I had a couple requests, mostly surrounding the API response type, and a suggestion for one of the helper functions.

[traeok]

Tested and LGTM! Thanks Andrew for addressing feedback and for the awesome enhancement 😋

[zFernand0]

Overall, LGTM! 😋

Not sure if this is something we have much control over, but noticed that the progress bar finished well before the completion of the search 😋

---

Also, should the search respect any filtered already applied?
Only 3 members matched, but the search is still looking at all 2000+ members.

[awharn]

Overall, LGTM! 😋

Not sure if this is something we have much control over, but noticed that the progress bar finished well before the completion of the search 😋

Also, should the search respect any filtered already applied? Only 3 members matched, but the search is still looking at all 2000+ members.

For the first, I am looking into it, since I am not quite sure why that is not working since I modeled the calls off of other items in the SDK. As for the second, I am not entirely sure if I can, since the SDK was never intended to search a subset of members for a PDS. It does not have that ability right now without a future enhancement, and even then it likely won't be able to filter a PDS's members if the search is performed on the session node.

[t1m0thyj]

LGTM, thanks @awharn!

[zFernand0]

LGTM! 😋