Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree(ds): Creating a new member with a conflicting name may cause data-loss #3327

Open
zFernand0 opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
bug Something isn't working needs-ported Apply to issues or PRs that need ported priority-high Production outage - this quarter or at least next quarter severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases

Comments

@zFernand0
Copy link
Member

Describe the bug

Say that your HLQ.TEST.PDS contains a member called TEST. if you create a new member, and provide the name TEST, the data on your old member will be lost

To Reproduce

  1. Create a PDS (HLQ.TEST.PDS)
  2. Create a member called TEST
  3. Add some content and save the member
  4. Now, right click the PDS, and select "Create new member"
  5. Name it TEST
  6. Notice the conclict error:
image

And now your contents from step 3 are gone on the mainframe

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: MacOS
  • Zowe Explorer Version: 3.0.2

Additional context

This was discovered by @pujal0909 (Thank you! 🙏 ) when researching:

@zFernand0 zFernand0 added bug Something isn't working severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases labels Nov 18, 2024
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@traeok
Copy link
Member

traeok commented Nov 18, 2024

This will need backported to v2 - in both major versions, we allow users to create a new member with the same name even if the member already exists.

The issue exists due to calling Upload.bufferToDataSet with an existing member for the createDataSetMember API - since the member already exists, its contents are replaced with an empty buffer. Ideally, we can add validation from the Zowe Explorer side to make sure the member doesn't exist before calling the API.

@zFernand0 zFernand0 added the needs-ported Apply to issues or PRs that need ported label Nov 19, 2024
@JTonda JTonda added the priority-high Production outage - this quarter or at least next quarter label Nov 19, 2024
@zowe-robot zowe-robot moved this from New Issues to High Priority in Zowe Explorer for VS Code Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-ported Apply to issues or PRs that need ported priority-high Production outage - this quarter or at least next quarter severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases
Projects
Status: High Priority
Development

No branches or pull requests

3 participants