Fix V3 scans for client-side & generate separate VSCode notices bundle #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
awharn
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Looks good to me, and the bundled licenses look correct. Thanks, @MarkAckert
t1m0thyj
reviewed
Sep 30, 2024
| container: | ||
| image: zowe-docker-release.jfrog.io/ompzowe/zowecicd-license-base:latest | ||
| image: zowe-docker-snapshot.jfrog.io/ompzowe/zowecicd-license-base:test-timothy |
There was a problem hiding this comment.
@MarkAckert I'm happy to update the zowe-docker-release latest tag to include the updated ORT and pnpm install step if you'd like 😋
15 tasks
Signed-off-by: MarkAckert <[email protected]>
MarkAckert
added a commit
that referenced
this pull request
Sep 30, 2024
* Reapply "add pnpm support, respect lockfiles" This reverts commit 2d1046b. Signed-off-by: MarkAckert <[email protected]> * Fix V3 scans for client-side & generate separate VSCode notices bundle (#149) * Generate a separate VSCode notices bundle Signed-off-by: Timothy Johnson <[email protected]> * Add --ignore-scripts flag to Node project installs Signed-off-by: Timothy Johnson <[email protected]> * Update path-scurry dep to fix yarn build Signed-off-by: Timothy Johnson <[email protected]> * Install pnpm@8 in license scan workflow Signed-off-by: Timothy Johnson <[email protected]> * Try to upgrade ORT tool Signed-off-by: Timothy Johnson <[email protected]> * Test workflow with new image Signed-off-by: Timothy Johnson <[email protected]> * Exclude zedc cargo project from ZE licenses Signed-off-by: Timothy Johnson <[email protected]> * Update repoRules.json Signed-off-by: Timothy Johnson <[email protected]> * update docker image tag Signed-off-by: MarkAckert <[email protected]> --------- Signed-off-by: Timothy Johnson <[email protected]> Signed-off-by: MarkAckert <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> --------- Signed-off-by: MarkAckert <[email protected]> Signed-off-by: Timothy Johnson <[email protected]> Co-authored-by: Timothy Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating #146
zowe-explorer-vscodeinto a separate zip artifact. Previously the VSCode notices were being included with the zos components.--ignore-scriptsflag to npm/yarn/pnpm install commands. Since the--prodflag was added in Support PNPM, Respect Lockfiles #145, thepreparescript fails for some repos if it requires a dev dep (e.g.husky).test-timothytag. V15 had several errors causing it to fail parsing Cargo (CLI daemon) and PNPM (ZE) projects that were fixed by upgrading.@awharn @zFernand0 @traeok Please review the CLI and VSCode artifacts generated by the license workflow.