-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Node V16 #531
base: v2.x/staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Priyansh61 <[email protected]>
Signed-off-by: Priyansh61 <[email protected]>
Signed-off-by: Priyansh61 <[email protected]>
Signed-off-by: Priyansh61 <[email protected]>
While you're right that Node 16 does not build correctly, I don't believe this fixes all of them. I get an npm install issue with zlux-platform (zlux-platform isn't buildable, but you can build it indirectly via npm install in zlux-app-manager/bootstrap) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH, I see the issue. You're using Node 16.0.0 probably or something very early
This is a great start 👍 but we'll want it to work for the recommended verison of Node. Please use Node 16 LTS 16.16.0 or 16.20.0
@DivergentEuropeans I cant understand why it is failing on your system , I actually changed my node version to 16.20.0 and still the build is successfull, so should I upload the package-lock version along with package.json to ensure everything remains the same? Can you help me with the diagnosis here? |
@Priyansh61 It's possible this happens because I'm developing on Windows. I'll test this sometime, haven't forgotten about this PR, thank you |
Issue found, it was old NVM version on Windows |
@DivergentEuropeans Any other changes to address in this PR ? |
Proposed changes
Why doesn't the problem happen with node version 14 ?
How to fix this ?
Most of the problem is caused by the confict of angular dependency v12 and v11, they are not inter-compatible.
So i have updated all the dependency to use angular v12.
Which dependecies were causing issue ?
The above dependencies were causing the problem, I have updated them to use angular v12.
This PR addresses Issue: N.A.
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments