Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaults to Zowe yaml configuration #4017

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Martin-Zeithaml
Copy link
Collaborator

@Martin-Zeithaml Martin-Zeithaml commented Nov 22, 2024

Describe your pull request here:

With Zowe 2.17, there is a defaults.yaml file, which is always merged with current config. There are some consequences, which should be documented.

What might be confusing for users, is existing paragraph about Configuration override. This is using defaults defined inside the config only. With the defaults.yaml you have another sets of defaults, which makes it complicated to describe and use.

Note: The defaults.yaml file and the merging of configs was added in 2.17.

List the file(s) included in this PR:
docs/appendix/zowe-yaml-configuration.md

After creating the PR, follow the instructions in the comments.

@Martin-Zeithaml Martin-Zeithaml added wip: do not merge area: install and config Issues related to z/OS install and config release: V3 Zowe V3 content labels Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

Copy link

github-actions bot commented Nov 22, 2024

@github-actions github-actions bot temporarily deployed to pull request November 22, 2024 07:06 Inactive
Signed-off-by: Martin Zeithaml <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 10:02 Inactive
Signed-off-by: Martin Zeithaml <[email protected]>
@Martin-Zeithaml Martin-Zeithaml added review: doc Needs review by Doc Squad member release: V2 Zowe V2 content and removed wip: do not merge labels Nov 25, 2024
@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 10:19 Inactive
### Configuration override
### Configuration override - defaults.yaml

There is a [`defaults.yaml`](https://github.com/zowe/zowe-install-packaging/blob/v3.x/staging/files/defaults.yaml) file, which defines values for global configuration and components. This file is always merged with current config(s) when `configmgr` is used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this address be v3.x/master and not v3.x/staging when this goes GA? Should this PR be targeting master or docs-staging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaults.yaml feature was added to Zowe 2.17. This should go to 2.17 and later. And V3 too.


For example, if you decide to remove `zowe.job` section by commenting or deleting, after the merging with the defaults the `zowe.job` section will be present again:

**Example of user config:**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be useful to show the initial configuration prior to the user config.

Signed-off-by: Martin Zeithaml <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 26, 2024 15:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 26, 2024 15:53 Inactive
Signed-off-by: Martin Zeithaml <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 26, 2024 16:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content release: V3 Zowe V3 content review: doc Needs review by Doc Squad member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants