Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webui and misc docs for v3 #3918

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Fix webui and misc docs for v3 #3918

merged 8 commits into from
Oct 8, 2024

Conversation

1000TurquoisePogs
Copy link
Member

This PR builds upon #3917 to fix branch sync issues. While doing review I also fixed a reference for JWT and a header.

Copy link

github-actions bot commented Oct 3, 2024

@github-actions github-actions bot temporarily deployed to pull request October 3, 2024 20:06 Inactive
Base automatically changed from update-master-with-misc-changes to master October 4, 2024 09:16
Copy link

github-actions bot commented Oct 4, 2024

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

Copy link

github-actions bot commented Oct 4, 2024

⚠️ Looks like something is wrong with the PR description. Remember to add a description and the file(s) included in this PR.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Copy link

github-actions bot commented Oct 4, 2024

📌 The subject area label is missing. Add an area: label so we know what your content is about.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Copy link

github-actions bot commented Oct 4, 2024

🔍 The review label is missing. Add a review: label so we can determine who needs to approve this PR.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Copy link

github-actions bot commented Oct 4, 2024

💾 The release label is missing. Add a release: label so your content is published with the correct major Zowe release.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

@zFernand0 zFernand0 self-requested a review October 4, 2024 12:37
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes not because this PR is bad, but to prevent it from being merged for now.

I found a commit that technically contains all of the changes that need to be reverted which I missed on my PR.

Thanks for opening this PR as it helped me pinpoint which commit I missed.

@github-actions github-actions bot temporarily deployed to pull request October 4, 2024 13:27 Inactive
@zFernand0
Copy link
Member

Hey @1000TurquoisePogs,
I rebased the branch and now the removal commits should show as no-files-changed

Remove mvd-conda remove RACF config
image image

@github-actions github-actions bot temporarily deployed to pull request October 8, 2024 15:24 Inactive
@anaxceron anaxceron merged commit 1731cf5 into master Oct 8, 2024
4 checks passed
@anaxceron anaxceron deleted the fix/v3/webui-misc-docs-2 branch October 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants