Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every page on every version has the same 'last updated' date #3712

Closed
ijmitch opened this issue Jun 11, 2024 · 6 comments
Closed

Every page on every version has the same 'last updated' date #3712

ijmitch opened this issue Jun 11, 2024 · 6 comments

Comments

@ijmitch
Copy link

ijmitch commented Jun 11, 2024

Description

As per title I'm seeing every page of every version of the docs with "Last updated: 11/06/2024" - so what's the point of having that if they're all the same?

Pages to Update

Every single page!

Screenshots

image

image

And the same 'Architecture' page from an older version:

image

Expected behavior

Additional context

@ijmitch
Copy link
Author

ijmitch commented Jun 12, 2024

I must admit I'd not spotted the day on all the pages was actually yesterday's date - ie the day when I created this issue. Checking today, it's still saying the same thing (so it's not like this gets fixed as "today's date"). Did something happen yesterday to make all the pages appear changed?

@balhar-jakub
Copy link
Member

Yes, we were publishing the 1.28.7 release yesterday, which means that all the pages were touched, but not necessarily changed.

I believe it's relevant bug to look into. Make sure that the last updated changes only for pages where content actually changed.

@ijmitch
Copy link
Author

ijmitch commented Jun 12, 2024

@balhar-jakub ah, OK - so at least it can be associated with an action.

So is this implemented via the showLastUpdateTime option? That should work off commit history - was there a mass commit somewhere?

@ijmitch
Copy link
Author

ijmitch commented Jun 12, 2024

You probably suffered this facebook/docusaurus#9734.

The problem is that the default depth for the actions/checkout@v4 action is 1 (latest commit only), and in this case git log cannot retrieve the dates of previous commits; instead it returns the date of the latest commit (the only one cloned), for all files, and all documentation pages appear to be updated at the same time.

Which boils down to the build process not having enough/any commit history.

@balhar-jakub
Copy link
Member

I am trying fix to this in the PR - #3715

@balhar-jakub
Copy link
Member

The fix was merged and deployed. As such I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants