Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Address UX comments and improve responsiveness #3082

Merged
merged 50 commits into from
Sep 27, 2023
Merged

chore: Address UX comments and improve responsiveness #3082

merged 50 commits into from
Sep 27, 2023

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Sep 15, 2023 •
edited by pablocarle
Loading

Description

Improve responsiveness and add mobile hamburger menu.
Address UX comments.

Type of change

  • (chore) Chore, repository cleanup, updates the dependencies.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

@taban03
add mike work
cdae50d 
Signed-off-by: at670475 <[email protected]>
@taban03 taban03 marked this pull request as draft September 15, 2023 13:51
ms895784 and others added 10 commits September 18, 2023 16:23
@ms895784 @bl893166
Private/ms895784/feedback form (#3083)
05175e8 
* chore[ui]: Update UI per suggestions from UX
Update screens with notes from jan/mirek

Signed-off-by: Mike Simpson <[email protected]>

* style fab button

* rebase

* flex direction column footer

* unbroke the dashboard footer, now details has too many scrollbars

* Supress more swagger details

* Feeback in own component, hide license on details

* Footer wrapping better, hide feedback button on small screens

* mobile navigations

* changed favicon

* fix menu animation, move open/close fn

* img size

* wip changes for tiles?

* Looks ok on small, not so good on big

* flexing tiles

* lint fixup

* Hardcode tech docs, param for feedback

* remove margin on techdoc in mobile menu

* more feedback tweaks

* fixed up header to be img text img

* fix flex issues, mobile zowe links, footer tweaks

* text align

* merge

* fix scroll issue

* fix lint error

* cleanup swagger param spacing

* space between try it out button and param header, space between params, hide example

* Make brett happier with fonts

* Pivot from provided html for to custom react form for feedback

* feedback ui

* Fixup tests, cleanup some lint, make old website work.

* finish feedback UI

* lint cleanup

* uncomment for test fix

* hide instance info on apiportal, not zowe

* negate

---------

Signed-off-by: Mike Simpson <[email protected]>
Co-authored-by: Brian Lee <[email protected]>
@taban03
Merge branch 'v2.x.x' into reboot/mike_work
6597211
@taban03
fixes
cd58cd5 
Signed-off-by: at670475 <[email protected]>
@taban03
add back package lock
1f6a46f 
Signed-off-by: at670475 <[email protected]>
@ms895784
Private/ms895784/more UI fixes (#3089)
2d12d39 
* Fix zowe tile styling, add color to api explorer separator

* Try to hookup the form to the submission company
@taban03
cleaning
4ca6de9 
Signed-off-by: at670475 <[email protected]>
@taban03
cleaning
edb888b 
Signed-off-by: at670475 <[email protected]>
@taban03
unignore tests
1362743 
Signed-off-by: at670475 <[email protected]>
@taban03
remove feedback services
8d94bcd 
Signed-off-by: at670475 <[email protected]>
@taban03
Merge branch 'v2.x.x' into reboot/mike_work
a198460
@taban03 taban03 changed the title feat: More UI fixes chore: More UI fixes Sep 19, 2023
@taban03 taban03 changed the title chore: More UI fixes fix: More UI fixes Sep 19, 2023
@taban03 taban03 changed the title fix: More UI fixes chore: Address UX comments and improve responsiveness Sep 19, 2023
@taban03 taban03 marked this pull request as ready for review September 21, 2023 14:15
taban03 and others added 21 commits September 25, 2023 11:00
@taban03
Merge branch 'v2.x.x' into reboot/mike_work
2c6d003
@taban03
refactoring
bf626fb 
Signed-off-by: at670475 <[email protected]>
@taban03
tests
1b0af59 
Signed-off-by: at670475 <[email protected]>
@taban03
add tests
a75f7e5 
Signed-off-by: at670475 <[email protected]>
@taban03
Merge branch 'v2.x.x' into reboot/mike_work
f68d70f
add types for jest and enzyme, add app.jsx UT
64e9da4 
Signed-off-by: Pablo Hernán Carle <[email protected]>
Merge branch 'reboot/mike_work' of https://github.com/zowe/api-layer …
f22f747 
…into reboot/mike_work
remove caret and console log
e4acfd3 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@taban03
add tests
bfd668d 
Signed-off-by: at670475 <[email protected]>
@taban03
change test title
a0488f4 
Signed-off-by: at670475 <[email protected]>
improve detailpage test
4127869 
Signed-off-by: Pablo Hernán Carle <[email protected]>
Merge branch 'reboot/mike_work' of https://github.com/zowe/api-layer …
1f7503d 
…into reboot/mike_work
lazy initialization test
a40960d 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@taban03
add tests for utilsFunction
2f7f9f3 
Signed-off-by: at670475 <[email protected]>
@taban03
add test for app.jsx
5836d16 
Signed-off-by: at670475 <[email protected]>
@taban03
add test for the ServiceNavigationBar.test.jsx
4254eb2 
Signed-off-by: at670475 <[email protected]>
@taban03
fix test title
4259958 
Signed-off-by: at670475 <[email protected]>
@taban03
add before each to set the portal flag to false
e007028 
Signed-off-by: at670475 <[email protected]>
@taban03
add tests
72803c0 
Signed-off-by: at670475 <[email protected]>
@taban03
polish
0d470de 
Signed-off-by: at670475 <[email protected]>
fix swaggerui tests
b9a09ca 
Signed-off-by: Pablo Hernán Carle <[email protected]>
taban03 and others added 3 commits September 27, 2023 14:10
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@taban03 taban03 merged commit e3eacc4 into v2.x.x Sep 27, 2023
29 of 30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/mike_work branch September 27, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocarle pablocarle pablocarle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taban03 @pablocarle @ms895784