Skip to content

Commit

Permalink
chore: Cherry-pick modifications from V2 to V3 between 2023-01-19 and…
Browse files Browse the repository at this point in the history
… 2024-01-24 (#3289)

* support all type of blogs for both use cases and tutorials (#3275)

Signed-off-by: at670475 <[email protected]>

* chore: Sonar scanner runs with Java 17 (#3288)

* Separate coverage and sonar tasks.

Signed-off-by: Petr Weinfurt <[email protected]>

* Use variable for architecture

Signed-off-by: Petr Weinfurt <[email protected]>

* Use variable for architecture

Signed-off-by: Petr Weinfurt <[email protected]>

* Refine messages

Signed-off-by: Petr Weinfurt <[email protected]>

* Increase timeout

Signed-off-by: Petr Weinfurt <[email protected]>

---------

Signed-off-by: Petr Weinfurt <[email protected]>

* fix: Fix disabling EhCache (#3280)

---------

Signed-off-by: at670475 <[email protected]>
Signed-off-by: Petr Weinfurt <[email protected]>
Co-authored-by: Andrea Tabone <[email protected]>
Co-authored-by: Petr Weinfurt <[email protected]>
  • Loading branch information
3 people authored Jan 25, 2024
1 parent 29d69c9 commit 6762054
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1491,7 +1491,7 @@ jobs:
PublishResults:
needs: [CITests,CITestsWithInfinispan,CITestsZosmfRsu2012,CITestsWithRedisReplica,CITestsWithRedisSentinel,CITestsInternalPort,CloudGatewayProxy,CloudGatewayServiceRouting]
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 20

steps:
- uses: actions/checkout@v4
Expand All @@ -1500,6 +1500,8 @@ jobs:
ref: ${{ github.head_ref }}

- uses: ./.github/actions/setup
with:
jdkVersion: 17

- uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -1539,9 +1541,10 @@ jobs:
path: cloudgatewayservicerouting

- name: Code coverage and publish results
run: >
./gradlew --info coverage sonar -Dresults="containercitests/results,citestswithinfinispan/results,containercitestszosmfrsu2012/results,ContainerCITestsWithRedisReplica/results,ContainerCITestsWithRedisSentinel/results,containercitestsinternalport/results,cloudgatewayproxy/results,citestswebsocketchaoticha/results,cloudgatewayservicerouting/results,containercitestszaas/results"
-Psonar.host.url=$SONAR_HOST_URL -Dsonar.token=$SONAR_TOKEN -Partifactory_user=$ARTIFACTORY_USERNAME -Partifactory_password=$ARTIFACTORY_PASSWORD
run: |
export JAVA_HOME=$JAVA_HOME_17_${{ runner.arch }}
echo Execute Sonar scanner using Java 17: JAVA_HOME = $JAVA_HOME
./gradlew --info sonar -Psonar.host.url=$SONAR_HOST_URL -Dsonar.token=$SONAR_TOKEN -Partifactory_user=$ARTIFACTORY_USERNAME -Partifactory_password=$ARTIFACTORY_PASSWORD
env:
ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}
ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
Expand Down
2 changes: 1 addition & 1 deletion api-catalog-ui/frontend/src/utils/utilFunctions.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default function countAdditionalContents(service) {
(product) => service?.serviceId === product.name
) || { useCases: [], tutorials: [], videos: [], documentation: null };

const filteredUseCases = useCases?.filter(({ url, user }) => isValidUrl(url) && user);
const filteredUseCases = useCases?.filter(({ url }) => isValidUrl(url));
const filteredTutorials = tutorials?.filter(({ url }) => isValidUrl(url));
const useCasesCounter = countValidItems(filteredUseCases, (item) => isValidUrl(item.url));
const tutorialsCounter = countValidItems(filteredTutorials, (item) => isValidUrl(item.url));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
@Configuration
@RequiredArgsConstructor
// There is an issue - clashing of XML configuration
@DependsOn({"cacheConfig", "cacheManagerFactoryBean"})
@DependsOn({"cacheConfig", "cacheManager"})
public class DiscoveryClientConfig {
private final AbstractDiscoveryClientOptionalArgs<?> optionalArgs;
private final ApimlDiscoveryClientFactory apimlDiscoveryClientFactory;
Expand Down

0 comments on commit 6762054

Please sign in to comment.