Add check for ZOPEN_ROOTFS before refreshing zopen #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run tests |
| @@ -138,7 +138,9 @@ zopen_install() | |||
|
|
|||
| zopen_append_to_setup() { | |||
| cat <<ZZ | |||
| \$PWD/bin/zopen init --refresh | |||
| if [ -n "\$ZOPEN_ROOTFS" ] && [ -d "\$ZOPEN_ROOTFS" ]; then | |||
| \$PWD/bin/zopen init --refresh | |||
There was a problem hiding this comment.
do you want to verify that $PWD/bin/zopen is executable first in case we move stuff around in the future and break this layout?
There was a problem hiding this comment.
There are probably other places we have this assumption so ok if we don't do this one - but seems a bit dangerous without a check
There was a problem hiding this comment.
Yeah, curl, git, and a few others :) Although we have checks in place for the return code there: https://github.com/ZOSOpenTools/gitport/blob/main/buildenv#L109
|
Depends on zopencommunity/meta#602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the situation when someone downloads metaport and initializes a new filesystem with
zopen init. We don't want to be refreshing something that does not exist.