Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallowed filters return data #44

Open
zwolf opened this issue Oct 30, 2019 · 1 comment
Open

Disallowed filters return data #44

zwolf opened this issue Oct 30, 2019 · 1 comment

Comments

@zwolf
Copy link
Member

zwolf commented Oct 30, 2019

Question: Should including filters that are not allowed by the allowed filters controller method return an error? Currently, it'll pass them through like it wasn't there. This is the intended behavior, but could cause confusion, especially during development of the FE.

@zwolf
Copy link
Member Author

zwolf commented Apr 4, 2024

Still an open issue (JSONAPI.rb issue 62) and won't be fixed on their side, so I need to at least make the call. Requires prevalidation and raising a 4xx ourselves.

@zwolf zwolf moved this to Maintenance in TOVE Dev Plan Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Maintenance
Development

No branches or pull requests

1 participant