Replies: 9 comments
-
|
@eatyourgreens could you share what project you used that demonstrates this bug? |
Beta Was this translation helpful? Give feedback.
-
|
Sure. It's my test project on staging, with the 'monorepo drawing tools' workflow: project 908, workflow: 3370 |
Beta Was this translation helpful? Give feedback.
-
|
Here's a real project that demonstrates the same behaviour. https://frontend.preview.zooniverse.org/projects/lbeiermann/worlds-of-wonder/classify/workflow/8871 |
Beta Was this translation helpful? Give feedback.
-
|
I don't understand the report. It seems to be functioning as intended with the hide previous marks button scoped in functionality to each task. If this is supposed to work differently, could you elaborate on what the expected behavior should be? |
Beta Was this translation helpful? Give feedback.
-
|
I think Hide Previous Marks persists across the steps of a workflow, but I'm really not sure. If I hide drawn marks, then I'm surprised if they become visible again without me changing the button state. I had a look at a few PRN projects, which use 'Hide Previous Marks' but their workflows all have a single drawing step. Maybe @beckyrother has UX advice on what we should expect to happen if we hide marks, then go back? |
Beta Was this translation helpful? Give feedback.
-
|
I've set up a workflow so that we can compare with PFE. The behaviour is weird, after going back from the second step: Hide Previous Marks is checked for 4 marks, but those 4 marks are all visible. Is the checkbox state wrong, or should the marks remain hidden? |
Beta Was this translation helpful? Give feedback.
-
|
Also, PFE feels a bit clunky after getting accustomed to that workflow in the new classifier. |
Beta Was this translation helpful? Give feedback.
-
|
I'm pretty sure we discussed this during implementation. I'll have to find it and we should document it. If I can find past discussion, I would recommend we leave the behavior as is because I think it's more clear as to what it should be doing at least to me compared to the PFE behavior. |
Beta Was this translation helpful? Give feedback.
-
|
I can find the original issue, but not the specific discussion about this; it might have been in slack chat and I'm not going to spend time trying to find it anymore. So, new discussion can happen here. Whatever the result of the discussion is here plus the original issue discussion where we decided on and implemented the variant in function between drawing task and transcription task will go into a belated ADR. |
Beta Was this translation helpful? Give feedback.
-
Package lib-classifier
Describe the bug
A clear and concise description of what the bug is.
Found while testing #2001: #2001 (comment)
Hide/Show previous marks is broken on a workflow with two drawing steps.
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.
Beta Was this translation helpful? Give feedback.
All reactions