Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] security warning for superagent during builds #7143

Closed
eatyourgreens opened this issue Jul 17, 2024 · 3 comments
Closed

[Security] security warning for superagent during builds #7143

eatyourgreens opened this issue Jul 17, 2024 · 3 comments

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Jul 17, 2024

Building PFE generates the following security warning in the build output (during the npm ci step.)

[email protected]: Please upgrade to v9.0.0+ as we have fixed a public vulnerability with formidable dependency. Note that v9.0.0+ requires Node.js v14.18.0+. See https://github.com/ladjs/superagent/pull/1800 for insight. This project is supported and maintained by the team at Forward Email @ https://forwardemail.net

Superagent probably needs to be upgraded in the API client, rather than directly in PFE. See zooniverse/panoptes-javascript-client#243.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Jul 22, 2024

The new API client, in the monorepo, is built on top of Superagent 8 too, so this warning affects all Zooniverse frontend projects (including Lab, Classrooms, Translations etc.)

https://github.com/zooniverse/front-end-monorepo/blob/f7b56e15c9b890535ef674caf623c130e48f32f5/packages/lib-panoptes-js/package.json#L19-L22

@eatyourgreens
Copy link
Contributor Author

Here’s the PR that’s linked from that warning.

@eatyourgreens
Copy link
Contributor Author

Superseded by zooniverse/panoptes-javascript-client#251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant