Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java dependency from main executable #17

Open
shehi opened this issue Jan 17, 2017 · 5 comments · May be fixed by #19
Open

Remove Java dependency from main executable #17

shehi opened this issue Jan 17, 2017 · 5 comments · May be fixed by #19

Comments

@shehi
Copy link
Contributor

shehi commented Jan 17, 2017

Hi @zoltan-dulac ,

Checking some forks made from this package, I noticed @raldred has made some significant improvements to the codebase at https://github.com/raldred/css3FontConverter. Could you please view his 3 additional commits in his fork and bring them in, to this original package?

@raldred
Copy link

raldred commented Jan 17, 2017

Beware my changes are 3 years old and Mac OSX specific

@shehi
Copy link
Contributor Author

shehi commented Oct 7, 2017

@zoltan-dulac , can you look at this one please? :)

@zoltan-dulac
Copy link
Owner

Hello.

I am more than willing to look into @raldred's changes (as well as the others). His changes are OSX specific and it will probably require a refactor to make sure everything works with other platforms.

I'll update this issue when I have looked into this. Thanks for the reminder. :-)

@zoltan-dulac
Copy link
Owner

@shehi : I have not added the changes requested since they are pretty specific to OSX (and since the code has a lot more features since his changes were made).

If you would like to add the OSX dfont support, I suggest extracting the font files from the dfont archive using fondu (which is what his fork uses). fondu can be installed using homebrew or macports, but if you want to compile yourself, I have set up a clone of the original repo (with some changes that will allow it compile under Cygwin for Windows) at:

https://github.com/zoltan-dulac/fondu

@shehi
Copy link
Contributor Author

shehi commented Dec 4, 2017

@zoltan-dulac , can we at least drop Java dependency from the main .sh file please? I have to install that huge platform (JVM) in my Docker because of this line:
https://github.com/zoltan-dulac/css3FontConverter/blob/master/convertFonts.sh#L478
Please let's get rid of java check there - we don't really need it, do we? Should I send in a PR for this?

@shehi shehi changed the title Pulling some changes from downstream: @raldred/css3FontConverter Remove Java dependency from main executable May 2, 2018
@shehi shehi linked a pull request May 2, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants