Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Description column #9

Open
michellabbe opened this issue Sep 30, 2021 · 5 comments
Open

[Feature request] Description column #9

michellabbe opened this issue Sep 30, 2021 · 5 comments

Comments

@michellabbe
Copy link

Just a suggestion: it would be useful to add a column to add a name/description to each line.

You can't save/parse it directly with netsh command, but you could keep these in a separate file in %localappdata%\PortProxyGUI or something.

"If column values match this, then description = this."
When creating/editing a rule (or comment), update the file too.

The same file/code could even be used to add other features like disable/enable rule, export/import feature, etc.

It would probably not be perfect, but could definitely be useful when you end up with alot of rules.

@zmjack
Copy link
Owner

zmjack commented Oct 4, 2021

Good suggestion that we will consider adding in the next version.

@zmjack
Copy link
Owner

zmjack commented Feb 22, 2022

The new version (v1.3.0) has been released, see if the new features get along well.

@michellabbe
Copy link
Author

Tried quickly (net 6 version). Seems to work fine.

I see that you create the config.db file in %userprofile%\Documents\PortProxyGUI folder.

Since netsh rules are system wide (and not per-user), you need to move the db file out of %userprofile% folder or it won't work on servers managed by multiple admins using their own user accounts.

My mistake for suggesting %localappdata%\PortProxyGUI (defaults to %userprofile%\AppData\Local\PortProxyGUI),
I meant %allusersprofile%\PortProxyGUI (defaults to C:\ProgramData\PortProxyGUI) which is a common appdata path for all users.

I also suggest making the comment column 2x or 3x wider by default on the next release. You rarely want to put only 1 word in there ;-)

Even better would be to remember window/columns size/positions between launches (make sure to check that it's not outside of visible screen), but I'll leave it up to you to create another feature request (or not) for this.

@YouveGotMeowxy
Copy link

The description and comment features are really nice; any way to automatically add 1 or both when doing a netsh interface portproxy command?

For example, I have a powershell script that auto deletes and creates new ports on bootup, with only the IP changing, and it would be really cool to persist those descriptions/comments.

@STaRDoGG
Copy link

I see that you create the config.db file in %userprofile%\Documents\PortProxyGUI folder.

Since netsh rules are system wide (and not per-user), you need to move the db file out of %userprofile% folder or it won't work on servers managed by multiple admins using their own user accounts.

My mistake for suggesting %localappdata%\PortProxyGUI (defaults to %userprofile%\AppData\Local\PortProxyGUI), I meant %allusersprofile%\PortProxyGUI (defaults to C:\ProgramData\PortProxyGUI) which is a common appdata path for all users.

I created a fork and moved the .db to the %localappdata% folder. Give it a try if interested:

https://github.com/STaRDoGG/PortProxyGUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants