Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug - 1.19.2] Incompatible with "ChatImage" #45

Open
KuryKat opened this issue Sep 9, 2023 · 5 comments · May be fixed by #46
Open

[Bug - 1.19.2] Incompatible with "ChatImage" #45

KuryKat opened this issue Sep 9, 2023 · 5 comments · May be fixed by #46
Labels

Comments

@KuryKat
Copy link

KuryKat commented Sep 9, 2023

Related to kitUIN/ChatImage#17

Describe the bug
Unable to launch the game when using ChatImage + It's the Little things because both export the same package...

To Reproduce

  1. Install Minecraft + Forge 43.2.23
  2. Install ChatImage 1.1.6
  3. Install ITLT (It's the little things) 2.2.0
  4. Try to Launch the Game
  5. Exception caught from launcher (check below for the logs)

Expected behavior
My game not crashing :)

Environment details

  • Windows 10
  • Java 17
  • Mod Version: 1.19.2-2.2.0
  • Minecraft version: 1.19.2

Logs and additional context

Exception caught from launcher
java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:58)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)
Caused by: java.lang.module.ResolutionException: Modules itlt and chatimage export package net.sf.image4j.util to module forge
	at java.base/java.lang.module.Resolver.resolveFail(Resolver.java:901)
	at java.base/java.lang.module.Resolver.failTwoSuppliers(Resolver.java:815)
	at java.base/java.lang.module.Resolver.checkExportSuppliers(Resolver.java:736)
	at java.base/java.lang.module.Resolver.finish(Resolver.java:380)
	at java.base/java.lang.module.Configuration.<init>(Configuration.java:140)
	at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:494)

Maybe this or this could help?

@KuryKat KuryKat added the bug label Sep 9, 2023
@kitUIN
Copy link

kitUIN commented Sep 11, 2023

ITLT that have the same module patch as ChatImage. It's unfixable. You can only delete the mods that have the same module.

@kitUIN
Copy link

kitUIN commented Sep 11, 2023

You can easily fix it by opening the ChatImage jar file and delete the folder net.sf.image4j

@KuryKat
Copy link
Author

KuryKat commented Sep 15, 2023

I can't do such a thing, since I am distributing the mods in my modpack, there's not a way for me to edit the jar and then release it with the modpack, and that could break some licenses even if I could 😅😅

@KuryKat
Copy link
Author

KuryKat commented Oct 13, 2023

I think this could be fixed with JarJar.... but not entirely sure, what do you guys think?

You can read more about JarJar here: https://forge.gemwire.uk/wiki/Jar-in-jar

KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
KuryKat added a commit to KuryKat/itlt that referenced this issue Oct 13, 2023
@KuryKat
Copy link
Author

KuryKat commented Oct 13, 2023

After some tests I managed to fix with simple relocation using the shadow plugin, quick fix

I tested on 1.19.2 and it worked, but it should work on any other version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants