Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting moving blocks, including the two unused ones #583

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

BlinkingBerry
Copy link
Collaborator

@BlinkingBerry BlinkingBerry commented Aug 25, 2024

Documented code relating to the moving blocks, moving block mover, and entities 8C and 8D (variations on the moving blocks that raise into the air instead of moving laterally. While usually they harmlessly shove Link away if he's under them as they fall, standing directly beneath one as it falls can leave Link stuck inside the block). Also fixed a few mistakes in the Blooper and Zol files (sorry about that).

Ref #200
Ref #142

Copy link
Collaborator

@kemenaran kemenaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice nice. A while ago I spent some time on these two entities, and couldn't figure out the "it's moving in Z, not in X". Cool to have this sorted out.

(Also the amount of code duplication in the original code is incredible…)

@BlinkingBerry BlinkingBerry merged commit 5a43a81 into zladx:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants