Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fvec_inner_product_batch_4_avx's calculation accuracy does not meet the requirements #871

Open
cydrain opened this issue Sep 26, 2024 · 3 comments
Assignees

Comments

@cydrain
Copy link
Collaborator

cydrain commented Sep 26, 2024

When enable "run_test()" in test_simd.cc:216
Screenshot from 2024-09-26 11-01-42

this case run fail with following error:

I0926 10:51:50.380264 1059789 test_simd.cc:54] [KNOWHERE][CATCH2_INTERNAL_TEST_10][knowhere_tests] simd type: 0, dim: 21
I0926 10:51:50.380273 1059789 knowhere_config.cc:64] [KNOWHERE][SetSimdType][knowhere_tests] FAISS expect simdType::AUTO
I0926 10:51:50.380282 1059789 knowhere_config.cc:89] [KNOWHERE][SetSimdType][knowhere_tests] FAISS hook AVX2
I0926 10:51:50.380350 1059789 knowhere_config.cc:95] [KNOWHERE][EnablePatchForComputeFP32AsBF16][knowhere_tests] Enable patch for compute fp32 as bf16
-------------------------------------------------------------------------------
Test distance
  test batch_4 distance calculation
-------------------------------------------------------------------------------
/home/caiyd/work/vec/knowhere/tests/ut/test_simd.cc:166
...............................................................................

/home/caiyd/work/vec/knowhere/tests/ut/test_simd.cc:202: FAILED:
  REQUIRE_THAT( dis2, Catch::Matchers::WithinRel(ref_ip_2, batch_tolerance) )
with expansion:
  -0.12995f and -0.0841045 are within 5% of each other
@cydrain
Copy link
Collaborator Author

cydrain commented Sep 26, 2024

/assign @foxspy

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label Oct 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2024
@adarshs1310
Copy link

What's the update on this issue? Is it fixed or not?

@cydrain cydrain reopened this Dec 9, 2024
@github-actions github-actions bot removed the stale label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants