Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device classes to number configuration entities #302

Open
TheJulianJES opened this issue Nov 25, 2024 · 0 comments
Open

Add device classes to number configuration entities #302

TheJulianJES opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@TheJulianJES
Copy link
Contributor

It looks like we don't set a device class for any of the number configuration entities provided in ZHA.

At least looking at the configuration entities with "celsius" as a unit, it looks like they could have the temperature device class.
We should consider adding them to ZHA and to number entities provided via v2 quirks.
I'm not sure if there's a real difference in the UI for number entities though?

Noticed here: zigpy/zha-device-handlers#3358 (comment)
Number platform: https://github.com/zigpy/zha/blob/dev/zha/application/platforms/number/__init__.py

We should also take a look at if this was missed in other platforms.

@TheJulianJES TheJulianJES added the enhancement New feature or request label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant