You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To test my fix, I added a modified copy of the Sinope quirk into the custom quirks directory (config/zhaquirks/sinope) in my live HA instance.
Although ZHA loads the modified quirk just fine, since the fix itself happens at definition time, my modifications are loaded too late in the process to fix the call to async_attach_trigger() in /zha/core/homeassistant/components/zha/device_trigger.py.
Instead, I had to ssh into HA OS as root and modify the zhaquirks code manually in /usr/local/lib/python3.12/site-packages/zhaquirks/sinope/__init__.py. This worked, but is pretty tedious if you're trying to iterate and test your changes.
I don't know if it's possible, but it would be nice if the loading order was changed such that if a custom quirk is present and it overrides an existing quirk, it would be loaded instead of the builtin one, and not after it.
Hi!
I noticed an issue while trying to debug the problem this PR fixes: zigpy/zha-device-handlers#3504
To test my fix, I added a modified copy of the Sinope quirk into the custom quirks directory (
config/zhaquirks/sinope
) in my live HA instance.Although ZHA loads the modified quirk just fine, since the fix itself happens at definition time, my modifications are loaded too late in the process to fix the call to
async_attach_trigger()
in/zha/core/homeassistant/components/zha/device_trigger.py
.Instead, I had to ssh into HA OS as root and modify the zhaquirks code manually in
/usr/local/lib/python3.12/site-packages/zhaquirks/sinope/__init__.py
. This worked, but is pretty tedious if you're trying to iterate and test your changes.I don't know if it's possible, but it would be nice if the loading order was changed such that if a custom quirk is present and it overrides an existing quirk, it would be loaded instead of the builtin one, and not after it.
cc @TheJulianJES
The text was updated successfully, but these errors were encountered: