Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFMXImageSlider.Clear handles ActivePage incorrectly #17

Open
vkrapotkin opened this issue Sep 2, 2019 · 0 comments
Open

TFMXImageSlider.Clear handles ActivePage incorrectly #17

vkrapotkin opened this issue Sep 2, 2019 · 0 comments

Comments

@vkrapotkin
Copy link 

procedure TFMXImageSlider.Clear;
...
  ActivePage := -1;

it will never be executed because

procedure TFMXImageSlider.SetActivePage(const Value: Integer);
...
  if (Value < 0) or (Value > FPages.Count - 1) then // check if value valid
    exit;

It prevents to set ActivePage=0 after clearing and reloading.

so we have to replace
ActivePage := -1; to FActivePage := -1;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vkrapotkin