Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible overcommit #59

Open
EricDeveaud opened this issue Oct 18, 2024 · 1 comment
Open

possible overcommit #59

EricDeveaud opened this issue Oct 18, 2024 · 1 comment

Comments

@EricDeveaud
Copy link

Hello,

number of processors to use is either hardcoded (4, 8) either set using multiprocessing.cpu_count()

problem is that multiprocessing.cpu_count() returns the number of available cpu, but this is not the same as the number of cpu available to the process. For example, you can run in a taskset context or a batch scheduler like slurm.

see:

$ nproc
96
$ taskset -c 1 nproc
1
$ taskset -c 1 python3 -c "import multiprocessing; print(multiprocessing.cpu_count())"
96

I would suggest to use len(os.sched_getaffinity(0)) instead of multiprocessing.cpu_count()

$ python3 -c "import os; print(len(os.sched_getaffinity(0)))"
96
$ taskset -c 1 python3 -c "import os; print(len(os.sched_getaffinity(0)))"
1

regards

Eric

@zhangrengang
Copy link
Owner

Hi Eric, thanks for your review and suggestion. I have changed it to len(os.sched_getaffinity(0)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants