You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Zetkin has a feature for importing people from Excel files or CSV files where every row is one person. When a user imports an Excel file or CSV, the file will often contain a first row which does not represent a person, but instead contain headers for the various columns. The importer can skip this row, and only generate people from the subsequent rows. However, when errors occur, the validation logic will report row numbers counted with the first row skipped. An error that occurs on the first person will be reported as "row 1", even though in the file it's on row 2 (because row 1 in the file is the header). The error message could be improved.
Description
Zetkin has a feature for importing people from Excel files or CSV files where every row is one person. When a user imports an Excel file or CSV, the file will often contain a first row which does not represent a person, but instead contain headers for the various columns. The importer can skip this row, and only generate people from the subsequent rows. However, when errors occur, the validation logic will report row numbers counted with the first row skipped. An error that occurs on the first person will be reported as "row 1", even though in the file it's on row 2 (because row 1 in the file is the header). The error message could be improved.
Steps to reproduce
Sample file
Expected Behaviour
An error should be reported on line 2, i.e. the first person, whose email address is invalid.
Actual Behaviour
An error is reported, but for line 1, by which it means the first person.
Screenshots (if you have any)
None
Proposed solution
Add +1 to all line numbers when reported in an error, if the "First row is headers" option is selceted.
The text was updated successfully, but these errors were encountered: