Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for specs_v1.json compatibility with system #82

Closed

Conversation

OGHO-SAYE
Copy link
Contributor

This fix closes #77

Creates a replicated version of specs_v1.json, and calls it specs.json for the system to recognize the proper file in dir.

…d specs.json, similar to load block features
Copy link

cla-assistant bot commented May 31, 2024

CLA assistant check
All committers have signed the CLA.

}

//call function to process core block directory
processCoreBlockDirectory(coreBlockDir);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this here I think we should check during the load process for this name and if it's specs_v1.json we should modify the filename and save it as specs.json, that way we would handle older block versions that may not be part of the core/blocks library

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll work on that, I did it this way, because this is similar to how it is handled using the load block button from the dropdown menu.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Instead of converting the spec files when the app start, we can just try to load both specs_v1.json and specs.json when something tries to access the specs for block in the readSpecs function.

@jmagoon jmagoon closed this Aug 19, 2024
@OGHO-SAYE OGHO-SAYE deleted the f/specs_v1.json_compatibility branch November 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no such file or directory" error when using specs_v1.json
3 participants