Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uint256 instead of uint64 for amount in revert context #375

Closed
lumtis opened this issue Oct 3, 2024 · 0 comments · Fixed by #377
Closed

Use uint256 instead of uint64 for amount in revert context #375

lumtis opened this issue Oct 3, 2024 · 0 comments · Fixed by #377
Assignees
@skosito
Labels
priority:high to-backport PR must be backported to active release

Comments

@lumtis
Copy link
Member

lumtis commented Oct 3, 2024

All amount should be uint256

protocol-contracts/v2/contracts/Revert.sol

Line 26 in 8d665c0

uint64 amount;

@lumtis lumtis added priority:high to-backport PR must be backported to active release labels Oct 3, 2024
@skosito skosito self-assigned this Oct 4, 2024
@skosito skosito linked a pull request Oct 4, 2024 that will close this issue
fix: revert ctx amount should be uint256 #377
Merged
@coderabbitai coderabbitai bot mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skosito skosito

Labels
priority:high to-backport PR must be backported to active release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: revert ctx amount should be uint256 zeta-chain/protocol-contracts
2 participants
@lumtis @skosito