Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FUNGIBLE_MODULE_ADDRESS into PROTOCOL_ADDRESS or something more explicit #351

Closed
lumtis opened this issue Sep 13, 2024 · 0 comments · Fixed by #353
Closed

Rename FUNGIBLE_MODULE_ADDRESS into PROTOCOL_ADDRESS or something more explicit #351

lumtis opened this issue Sep 13, 2024 · 0 comments · Fixed by #353
Assignees

Comments

@lumtis
Copy link
Member

lumtis commented Sep 13, 2024

If you look only at the protocol contract without ZetaCore, it is a bit unclear what fungible means.

This address represents the protocol that can do admin action on ZetaChain. I propose to rename it to something like

  • ProtocolAddress
  • ProtocolAuthority
  • ProtocolAdmin
@skosito skosito self-assigned this Sep 13, 2024
@skosito skosito linked a pull request Sep 13, 2024 that will close this issue
@skosito skosito closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants