Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from git submodules to Soldeer #320

Closed
fadeev opened this issue Aug 14, 2024 · 0 comments · Fixed by #337
Closed

Migrate from git submodules to Soldeer #320

fadeev opened this issue Aug 14, 2024 · 0 comments · Fixed by #337
Assignees

Comments

@fadeev
Copy link
Member

fadeev commented Aug 14, 2024

Soldeer is a Solidity package manager integrated with forge: https://soldeer.xyz/

I propose we:

  • Install everything that's available from npm
  • Install everything else from Soldeer
  • If we use a Soldeer dependency in one of the contracts in the contracts/ dir, we add this dependency in git, so that when protocol contracts are installed through npm it still works.
  • Not use git submodules

It's not great to have two package managers, but some things like forge-std are not available on npm.

We can't not use npm, because ABIs need to be published there for frontend clients to use.

@skosito skosito self-assigned this Aug 19, 2024
@skosito skosito linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants