Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GatewayZEVM: executeRevert - remove ZRC20, amount and message #319

Closed
lumtis opened this issue Aug 13, 2024 · 0 comments · Fixed by #316
Closed

GatewayZEVM: executeRevert - remove ZRC20, amount and message #319

lumtis opened this issue Aug 13, 2024 · 0 comments · Fixed by #316
Assignees
@skosito

Comments

@lumtis
Copy link
Member

lumtis commented Aug 13, 2024

This function is used either:

  • no asset so zrc20 would be zero
  • Zeta tokens, the ZETA are deposit by the protocol, same behavior as no asset

All these fields can therefore be removed from the function.

We can message from depositAndRevert that is not used
@skosito skosito self-assigned this Aug 13, 2024
@skosito skosito linked a pull request Aug 13, 2024 that will close this issue
fix: various fixes #316
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skosito skosito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: various fixes zeta-chain/protocol-contracts
2 participants
@lumtis @skosito