Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm publishing #32

Closed
fadeev opened this issue Sep 23, 2024 · 5 comments · Fixed by #57
Closed

Fix npm publishing #32

fadeev opened this issue Sep 23, 2024 · 5 comments · Fixed by #57
Labels

Comments

@fadeev
Copy link
Member

fadeev commented Sep 23, 2024

Run yarn publish --access public --new-version ${GITHUB_REF#refs/tags/v} --tag  --no-git-tag-version
yarn publish v1.22.22
warning package.json: License should be a valid SPDX license expression
warning package.json: License should be a valid SPDX license expression
[1/4] Bumping version...
info Current version: 0.0.0-set-on-publish
info New version: 1.0.0
[2/4] Logging in...
error No token found and can't prompt for login when running with --non-interactive.
info Visit https://yarnpkg.com/en/docs/cli/publish for documentation about this command.

https://github.com/zeta-chain/protocol-contracts-solana/actions/runs/10995181716/job/30525382400

@fadeev fadeev added the ci label Sep 23, 2024
@fadeev
Copy link
Member Author

fadeev commented Sep 25, 2024

@zeta-chain/devops if you can take a look, that'd be great.

@gartnera
Copy link
Member

env:
          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

seems to be missing on yarn publish ?

@fadeev
Copy link
Member Author

fadeev commented Sep 27, 2024

env:
          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

seems to be missing on yarn publish ?

- name: Setup Node.js for NPM Publish
uses: actions/setup-node@v4
with:
node-version: '21.0.0'
registry-url: 'https://registry.npmjs.org'
auth-token: ${{ secrets.NPM_TOKEN }}

setup-node@v4 should be setting up .npmrc, which yarn should pick up.

@fadeev
Copy link
Member Author

fadeev commented Oct 17, 2024

@zeta-chain/devops please, take a look when you have the time 🙏

@gartnera
Copy link
Member

I don't see auth-token in the action inputs? https://github.com/actions/setup-node/blob/main/action.yml

@fadeev fadeev linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants