refactor: deprecate x/params

app/app.go

@@ -382,11 +382,11 @@ func New(
 		appCodec,
 		keys[observertypes.StoreKey],
 		keys[observertypes.MemStoreKey],
-		app.GetSubspace(observertypes.ModuleName),
 		&stakingKeeper,
 		app.SlashingKeeper,
 		app.AuthorityKeeper,
 		app.LightclientKeeper,
+		authtypes.NewModuleAddress(govtypes.ModuleName).String(),
 	)
 
 	// register the staking hooks
@@ -406,12 +406,12 @@ func New(
 		appCodec,
 		keys[emissionstypes.StoreKey],
 		keys[emissionstypes.MemStoreKey],
-		app.GetSubspace(emissionstypes.ModuleName),
 		authtypes.FeeCollectorName,
 		app.BankKeeper,
 		app.StakingKeeper,
 		app.ObserverKeeper,
 		app.AccountKeeper,
+		authtypes.NewModuleAddress(govtypes.ModuleName).String(),
 	)
 
 	// Create Ethermint keepers
@@ -527,7 +527,7 @@ func New(
 		crosschainmodule.NewAppModule(appCodec, app.CrosschainKeeper),
 		observermodule.NewAppModule(appCodec, *app.ObserverKeeper),
 		fungiblemodule.NewAppModule(appCodec, app.FungibleKeeper),
-		emissionsmodule.NewAppModule(appCodec, app.EmissionsKeeper),
+		emissionsmodule.NewAppModule(appCodec, app.EmissionsKeeper, app.GetSubspace(emissionstypes.ModuleName)),
 		authzmodule.NewAppModule(appCodec, app.AuthzKeeper, app.AccountKeeper, app.BankKeeper, app.interfaceRegistry),
 	)
 
@@ -821,9 +821,7 @@ func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino
 	paramsKeeper.Subspace(evmtypes.ModuleName)
 	paramsKeeper.Subspace(feemarkettypes.ModuleName)
 	paramsKeeper.Subspace(group.ModuleName)
-	paramsKeeper.Subspace(crosschaintypes.ModuleName)
 	paramsKeeper.Subspace(observertypes.ModuleName)
-	paramsKeeper.Subspace(fungibletypes.ModuleName)
 	paramsKeeper.Subspace(emissionstypes.ModuleName)
 	return paramsKeeper
 }

app/setup_handlers.go

@@ -6,20 +6,30 @@ import (
 	"github.com/cosmos/cosmos-sdk/types/module"
 	"github.com/cosmos/cosmos-sdk/x/upgrade/types"
 	authoritytypes "github.com/zeta-chain/zetacore/x/authority/types"
+	emissionstypes "github.com/zeta-chain/zetacore/x/emissions/types"
 	lightclienttypes "github.com/zeta-chain/zetacore/x/lightclient/types"
-	observertypes "github.com/zeta-chain/zetacore/x/observer/types"
 )
 
 const releaseVersion = "v15"
 
 func SetupHandlers(app *App) {
+	// Set param key table for params module migration
+	for _, subspace := range app.ParamsKeeper.GetSubspaces() {
+		subspace := subspace
+
+		switch subspace.Name() {
+		// TODO: add all modules when cosmos-sdk is updated
+		case emissionstypes.ModuleName:
+			subspace.WithKeyTable(emissionstypes.ParamKeyTable())
+		}
+	}
 	app.UpgradeKeeper.SetUpgradeHandler(releaseVersion, func(ctx sdk.Context, plan types.Plan, vm module.VersionMap) (module.VersionMap, error) {
 		app.Logger().Info("Running upgrade handler for " + releaseVersion)
 		// Updated version map to the latest consensus versions from each module
 		for m, mb := range app.mm.Modules {
 			vm[m] = mb.ConsensusVersion()
 		}
-		VersionMigrator{v: vm}.TriggerMigration(observertypes.ModuleName)
+		VersionMigrator{v: vm}.TriggerMigration(emissionstypes.ModuleName)
 
 		return app.mm.RunMigrations(ctx, app.configurator, vm)
 	})

changelog.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## Unreleased
+
+### Refactor
+* [2014](https://github.com/zeta-chain/node/pull/2014) - remove params module
+
 ## Unreleased
 ### Breaking Changes
 

codecov.yml

@@ -61,6 +61,7 @@ ignore:
   - "**/*.yaml"
   - "**/*.pb.go"
   - "**/*.pb.gw.go"
+  - "**/*_legacy.go"
   - "**/*.json"
   - ".github/**/*"
   - "app/**/*"

contrib/localnet/scripts/start-zetacored.sh

@@ -121,8 +121,6 @@ then
   cat $HOME/.zetacored/config/genesis.json | jq '.app_state["authority"]["policies"]["items"][0]["address"]="zeta1srsq755t654agc0grpxj4y3w0znktrpr9tcdgk"' > $HOME/.zetacored/config/tmp_genesis.json && mv $HOME/.zetacored/config/tmp_genesis.json $HOME/.zetacored/config/genesis.json
   cat $HOME/.zetacored/config/genesis.json | jq '.app_state["authority"]["policies"]["items"][1]["address"]="zeta1srsq755t654agc0grpxj4y3w0znktrpr9tcdgk"' > $HOME/.zetacored/config/tmp_genesis.json && mv $HOME/.zetacored/config/tmp_genesis.json $HOME/.zetacored/config/genesis.json
   cat $HOME/.zetacored/config/genesis.json | jq '.app_state["authority"]["policies"]["items"][2]["address"]="zeta1srsq755t654agc0grpxj4y3w0znktrpr9tcdgk"' > $HOME/.zetacored/config/tmp_genesis.json && mv $HOME/.zetacored/config/tmp_genesis.json $HOME/.zetacored/config/genesis.json
-  cat $HOME/.zetacored/config/genesis.json | jq '.app_state["observer"]["params"]["admin_policy"][0]["address"]="zeta1srsq755t654agc0grpxj4y3w0znktrpr9tcdgk"' > $HOME/.zetacored/config/tmp_genesis.json && mv $HOME/.zetacored/config/tmp_genesis.json $HOME/.zetacored/config/genesis.json
-  cat $HOME/.zetacored/config/genesis.json | jq '.app_state["observer"]["params"]["admin_policy"][1]["address"]="zeta1srsq755t654agc0grpxj4y3w0znktrpr9tcdgk"' > $HOME/.zetacored/config/tmp_genesis.json && mv $HOME/.zetacored/config/tmp_genesis.json $HOME/.zetacored/config/genesis.json
 
 # give balance to runner accounts to deploy contracts directly on zEVM
 # deployer

docs/cli/zetacored/zetacored_query_observer.md

@@ -36,7 +36,6 @@ zetacored query observer [flags]
 * [zetacored query observer list-observer-set](zetacored_query_observer_list-observer-set.md)	 - Query observer set
 * [zetacored query observer list-pending-nonces](zetacored_query_observer_list-pending-nonces.md)	 - shows a chainNonces
 * [zetacored query observer list-tss-history](zetacored_query_observer_list-tss-history.md)	 - show historical list of TSS
-* [zetacored query observer params](zetacored_query_observer_params.md)	 - shows the parameters of the module
 * [zetacored query observer show-ballot](zetacored_query_observer_show-ballot.md)	 - Query BallotByIdentifier
 * [zetacored query observer show-blame](zetacored_query_observer_show-blame.md)	 - Query BlameByIdentifier
 * [zetacored query observer show-chain-nonces](zetacored_query_observer_show-chain-nonces.md)	 - shows a chainNonces

docs/openapi/openapi.swagger.yaml

@@ -27239,7 +27239,7 @@ paths:
         "200":
           description: A successful response.
           schema:
-            $ref: '#/definitions/zetacoreemissionsQueryParamsResponse'
+            $ref: '#/definitions/emissionsQueryParamsResponse'
         default:
           description: An unexpected error response.
           schema:
@@ -28098,21 +28098,6 @@ paths:
             $ref: '#/definitions/googlerpcStatus'
       tags:
         - Query
-  /zeta-chain/observer/params:
-    get:
-      summary: Parameters queries the parameters of the module.
-      operationId: Query_Params
-      responses:
-        "200":
-          description: A successful response.
-          schema:
-            $ref: '#/definitions/zetacoreobserverQueryParamsResponse'
-        default:
-          description: An unexpected error response.
-          schema:
-            $ref: '#/definitions/googlerpcStatus'
-      tags:
-        - Query
   /zeta-chain/observer/pendingNonces:
     get:
       operationId: Query_PendingNoncesAll
@@ -53995,8 +53980,35 @@ definitions:
       ed25519:
         type: string
     title: PubKeySet contains two pub keys , secp256k1 and ed25519
+  emissionsMsgUpdateParamsResponse:
+    type: object
   emissionsMsgWithdrawEmissionResponse:
     type: object
+  emissionsParams:
+    type: object
+    properties:
+      max_bond_factor:
+        type: string
+      min_bond_factor:
+        type: string
+      avg_block_time:
+        type: string
+      target_bond_ratio:
+        type: string
+      validator_emission_percentage:
+        type: string
+      observer_emission_percentage:
+        type: string
+      tss_signer_emission_percentage:
+        type: string
+      duration_factor_constant:
+        type: string
+      observer_slash_amount:
+        type: string
+      ballot_maturity_blocks:
+        type: string
+        format: int64
+    description: Params defines the parameters for the module.
   emissionsQueryGetEmissionsFactorsResponse:
     type: object
     properties:
@@ -54015,6 +54027,13 @@ definitions:
         type: string
       emission_module_address:
         type: string
+  emissionsQueryParamsResponse:
+    type: object
+    properties:
+      params:
+        $ref: '#/definitions/emissionsParams'
+        description: params holds all the parameters of this module.
+    description: QueryParamsResponse is response type for the Query/Params RPC method.
   emissionsQueryShowAvailableEmissionsResponse:
     type: object
     properties:
@@ -54228,14 +54247,6 @@ definitions:
       btcTypeChainEnabled:
         type: boolean
     title: VerificationFlags is a structure containing information which chain types are enabled for block header verification
-  observerAdmin_Policy:
-    type: object
-    properties:
-      policy_type:
-        $ref: '#/definitions/observerPolicy_Type'
-      address:
-        type: string
-    title: Deprecated(v14):Moved into the authority module
   observerBallotStatus:
     type: string
     enum:
@@ -54466,18 +54477,6 @@ definitions:
       - TSSKeyGen
       - TSSKeySign
     default: EmptyObserverType
-  observerObserverParams:
-    type: object
-    properties:
-      chain:
-        $ref: '#/definitions/chainsChain'
-      ballot_threshold:
-        type: string
-      min_observer_delegation:
-        type: string
-      is_supported:
-        type: boolean
-    title: 'Deprecated(v13): Use ChainParamsList'
   observerObserverUpdateReason:
     type: string
     enum:
@@ -54500,13 +54499,6 @@ definitions:
       tss:
         type: string
     title: store key is tss+chainid
-  observerPolicy_Type:
-    type: string
-    enum:
-      - group1
-      - group2
-    default: group1
-    title: Deprecated(v14):Moved into the authority module
   observerQueryAllBlameRecordsResponse:
     type: object
     properties:
@@ -54819,61 +54811,6 @@ definitions:
         format: int64
       isAbortRefunded:
         type: boolean
-  zetacoreemissionsParams:
-    type: object
-    properties:
-      max_bond_factor:
-        type: string
-      min_bond_factor:
-        type: string
-      avg_block_time:
-        type: string
-      target_bond_ratio:
-        type: string
-      validator_emission_percentage:
-        type: string
-      observer_emission_percentage:
-        type: string
-      tss_signer_emission_percentage:
-        type: string
-      duration_factor_constant:
-        type: string
-      observer_slash_amount:
-        type: string
-    description: Params defines the parameters for the module.
-  zetacoreemissionsQueryParamsResponse:
-    type: object
-    properties:
-      params:
-        $ref: '#/definitions/zetacoreemissionsParams'
-        description: params holds all the parameters of this module.
-    description: QueryParamsResponse is response type for the Query/Params RPC method.
-  zetacoreobserverParams:
-    type: object
-    properties:
-      observer_params:
-        type: array
-        items:
-          type: object
-          $ref: '#/definitions/observerObserverParams'
-        title: 'Deprecated(v13): Use ChainParamsList'
-      admin_policy:
-        type: array
-        items:
-          type: object
-          $ref: '#/definitions/observerAdmin_Policy'
-        title: Deprecated(v14):Moved into the authority module
-      ballot_maturity_blocks:
-        type: string
-        format: int64
-    description: Params defines the parameters for the module.
-  zetacoreobserverQueryParamsResponse:
-    type: object
-    properties:
-      params:
-        $ref: '#/definitions/zetacoreobserverParams'
-        description: params holds all the parameters of this module.
-    description: QueryParamsResponse is response type for the Query/Params RPC method.
   ethermint.evm.v1.ChainConfig:
     type: object
     properties:

docs/spec/emissions/messages.md

@@ -1,5 +1,14 @@
 # Messages
 
+## MsgUpdateParams
+
+```proto
+message MsgUpdateParams {
+	string authority = 1;
+	Params params = 2;
+}
+```
+
 ## MsgWithdrawEmission
 
 WithdrawEmission allows the user to withdraw from their withdrawable emissions.

proto/emissions/params.proto

@@ -20,4 +20,5 @@ message Params {
     (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Int",
     (gogoproto.nullable) = false
   ];
+  int64 ballot_maturity_blocks = 10;
 }

proto/emissions/tx.proto

@@ -1,12 +1,14 @@
 syntax = "proto3";
 package zetachain.zetacore.emissions;
 
+import "emissions/params.proto";
 import "gogoproto/gogo.proto";
 
 option go_package = "github.com/zeta-chain/zetacore/x/emissions/types";
 
 // Msg defines the Msg service.
 service Msg {
+  rpc UpdateParams(MsgUpdateParams) returns (MsgUpdateParamsResponse);
   rpc WithdrawEmission(MsgWithdrawEmission) returns (MsgWithdrawEmissionResponse);
 }
 
@@ -19,3 +21,10 @@ message MsgWithdrawEmission {
 }
 
 message MsgWithdrawEmissionResponse {}
+
+message MsgUpdateParams {
+  string authority = 1;
+  Params params = 2 [(gogoproto.nullable) = false];
+}
+
+message MsgUpdateParamsResponse {}

proto/observer/genesis.proto

@@ -22,7 +22,6 @@ message GenesisState {
   ObserverSet observers = 2 [(gogoproto.nullable) = false];
   repeated NodeAccount nodeAccountList = 3;
   CrosschainFlags crosschain_flags = 4;
-  Params params = 5;
   Keygen keygen = 6;
   LastObserverCount last_observer_count = 7;
   ChainParamsList chain_params_list = 8 [(gogoproto.nullable) = false];