HAL 01: Zeta supply does not track assets correctly

[fadeev]

Tasks

Preview Give feedback

1. zetaclient : Add a new thread which runs the supply check #1352
   zetaclient +1
2. zetaclient zetacore : Post Error in case the check fails. #1353
   zetaclient +1
3. zetaclient : Decide and implement the frequency when to run the checks #1354
   zetaclient +1
4. zetaclient : Add Unit tests for supply check functions #1355
   zetaclient +1

[lumtis]

@kingpinXD can we break down into several tasks?

[CharlieMc0]

Is this completed? @lumtis @kingpinXD ?

[kingpinXD]

No, it's not
The supply checker initially implemented was disabled as we planned to test it on Athens to determine the frequency of these checks so that the notifications are helpful.

This would need to be prioritised / revisited to enable it backup again . Based on the current codebase , we would need to refactor the checking function

[lumtis]

We decided to go with monitoring + using emergency proposals

The previous ZetaClient implementation was bloated since requiring new queries and unclear process to report accounting issues.
There is no reason for ZetaClient to be in charge of this if emergency proposals are executed by external parties

What we should do is refactor to use a lock/unlock model for ZETA instead of mint/burn for non-Ethereum chians but we should first decide if we want to transition ZETA to the contract v2 model

[lumtis]

Closing in favor of #881