Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the crosschain swap test to use V2 or add new one #3177

Closed
lumtis opened this issue Nov 18, 2024 · 0 comments · Fixed by #3188
Closed

Change the crosschain swap test to use V2 or add new one #3177

lumtis opened this issue Nov 18, 2024 · 0 comments · Fixed by #3188
Assignees
@skosito
Labels
E2E E2E tests related

Comments

@lumtis
Copy link
Member

lumtis commented Nov 18, 2024

Describe the Issue

Using Uniswap pool in onCall processing seem to have some unique behavior regarding the processing of inbounds, example: when executing the tx without gas limit.

We should add a test case under the v2 test suite to cover this case.

  • Change the current crosschain swap test
  • Add a new test
@lumtis lumtis added the E2E E2E tests related label Nov 18, 2024
@skosito skosito linked a pull request Nov 20, 2024 that will close this issue
test(e2e): add e2e test for v2 deposit and call with swap #3188
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skosito skosito

Labels
E2E E2E tests related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(e2e): add e2e test for v2 deposit and call with swap zeta-chain/node
2 participants
@lumtis @skosito