Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add liquidity failed #3173

Closed
Tracked by #3187
gartnera opened this issue Nov 15, 2024 · 1 comment · Fixed by #3199
Closed
Tracked by #3187

e2e: add liquidity failed #3173

gartnera opened this issue Nov 15, 2024 · 1 comment · Fixed by #3199
Assignees
Labels
bug Something isn't working ci Changes to CI pipeline or github actions

Comments

@gartnera
Copy link
Member

Random add liquidity failures in CI

https://github.com/zeta-chain/node/actions/runs/11840815330/job/32995675524

Error Trace:	/go/delivery/zeta-node/e2e/runner/liquidity.go:40
	            				/go/delivery/zeta-node/e2e/e2etests/test_operation_add_liquidity_eth.go:24
	Error:      	Not equal: 
	            	expected: 0x1
	            	actual  : 0x0
	Messages:   	add liquidity failed

https://github.com/zeta-chain/node/actions/runs/11846669335/job/33014873211

Error Trace:	/go/delivery/zeta-node/e2e/e2etests/test_erc20_deposit_refund.go:68
	Error:      	Received unexpected error:
	            	add liquidity failed
@gartnera gartnera added the bug Something isn't working label Nov 15, 2024
@gartnera gartnera changed the title cI: add liquidity failed e2e: add liquidity failed Nov 15, 2024
@gartnera gartnera added the ci Changes to CI pipeline or github actions label Nov 15, 2024
@kingpinXD kingpinXD self-assigned this Nov 21, 2024
@lumtis
Copy link
Member

lumtis commented Nov 22, 2024

One possible reason is test_crosschain_swap initialize liquidity with values or prices so small that the subsequent liquidity adding fail.

Reason that it would happen specifically in light upgrade test is that for those we run test_crosschain_swap first, then the new add liquidity function in the V2 test for the after upgrade testing

[EDIT] well not really as it create a pool ERC20/BTC unlike the other tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants