Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tests broken #2982

Closed
gartnera opened this issue Oct 8, 2024 · 1 comment · Fixed by #2983
Closed

Upgrade tests broken #2982

gartnera opened this issue Oct 8, 2024 · 1 comment · Fixed by #2983
Assignees
@gartnera
Labels
bug Something isn't working

Comments

@gartnera
Copy link
Member

gartnera commented Oct 8, 2024

#2952 broke the upgrade tests because the old version will not have the ErrorMessage field.

// Check the error carries the revert executed.
require.Contains(r, cctx.CctxStatus.ErrorMessage, "revert executed")
@gartnera gartnera added the bug Something isn't working label Oct 8, 2024
This was referenced Oct 8, 2024
Merged
Merged
Merged
@fbac fbac assigned fbac and gartnera and unassigned fbac Oct 8, 2024
@fbac
Copy link
Contributor

fbac commented Oct 9, 2024

Transferring ownership to @gartnera as he has a draft PR fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gartnera gartnera

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(e2e): tolerate revert message in both error and status message zeta-chain/node
2 participants
@gartnera @fbac